This review is from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

unknown

May have been packaged automatically without a review


This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of mp4parse is 0.17.0.

0.11.4 (older version) Rating: Neutral Thoroughness: Low Understanding: Medium

by kornelski on 2020-05-04

Fallible feature is unsound. The rest looks ok.


Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open mp4parse. Alternatively, you can download the tarball of mp4parse v0.17.0 or view the source online.

The crate tarball contains, among others, this file:

  • Zip file, 2KB: tests/corrupt/invalid-avif-colr-multiple.zip